From: Jan Kara Date: Fri, 16 Jun 2023 16:50:55 +0000 (+0200) Subject: ext4: drop read-only check in ext4_write_inode() X-Git-Tag: v6.6.7~1886^2~53 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f1128084b40e520bea8bb32b3ff4d03745ab7e64;p=platform%2Fkernel%2Flinux-starfive.git ext4: drop read-only check in ext4_write_inode() We should not have dirty inodes on read-only filesystem. Also silently bailing without writing anything would be a problem when we enable quotas during remount while the filesystem is read-only. So drop the read-only check. Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20230616165109.21695-9-jack@suse.cz Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 100c3ec..1b90038 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5129,8 +5129,7 @@ int ext4_write_inode(struct inode *inode, struct writeback_control *wbc) { int err; - if (WARN_ON_ONCE(current->flags & PF_MEMALLOC) || - sb_rdonly(inode->i_sb)) + if (WARN_ON_ONCE(current->flags & PF_MEMALLOC)) return 0; if (unlikely(ext4_forced_shutdown(inode->i_sb)))