From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Mon, 21 Apr 2014 14:58:45 +0000 (+0100)
Subject: rtpmux: fix buffer list drop check
X-Git-Tag: 1.19.3~509^2~4645
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f10c3f1a7648f79caaa01d379791d272737913c0;p=platform%2Fupstream%2Fgstreamer.git

rtpmux: fix buffer list drop check

While porting to 0.11, the check was mistakenly made constant,
instead of testing for the return value of process_buffer_locked.

Coverity 1139663
---

diff --git a/gst/rtpmanager/gstrtpmux.c b/gst/rtpmanager/gstrtpmux.c
index a4b4f39fec..1dc2da4324 100644
--- a/gst/rtpmanager/gstrtpmux.c
+++ b/gst/rtpmanager/gstrtpmux.c
@@ -412,7 +412,6 @@ gst_rtp_mux_chain_list (GstPad * pad, GstObject * parent,
   GstRTPMux *rtp_mux;
   GstFlowReturn ret;
   GstRTPMuxPadPrivate *padpriv;
-  gboolean drop = TRUE;
   struct BufferListData bd;
 
   rtp_mux = GST_RTP_MUX (parent);
@@ -436,7 +435,7 @@ gst_rtp_mux_chain_list (GstPad * pad, GstObject * parent,
 
   GST_OBJECT_UNLOCK (rtp_mux);
 
-  if (drop) {
+  if (bd.drop) {
     gst_buffer_list_unref (bufferlist);
     ret = GST_FLOW_OK;
   } else {