From: Uwe Kleine-König Date: Wed, 7 Jul 2021 16:28:29 +0000 (+0200) Subject: pwm: pca9685: Don't check the return code of pwmchip_remove() X-Git-Tag: accepted/tizen/unified/20230118.172025~6393^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f0e96e2e2cb292594483b0ff3cd00b45e386c45f;p=platform%2Fkernel%2Flinux-rpi.git pwm: pca9685: Don't check the return code of pwmchip_remove() pwmchip_remove() returns always 0. Don't use the value to make it possible to eventually change the function to return void. Also the driver core ignores the return value of pca9685_pwm_remove() and considers the device removed anyhow. So returning early results in a resource leak. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 42ed770..c56001a 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -601,11 +601,8 @@ static int pca9685_pwm_probe(struct i2c_client *client, static int pca9685_pwm_remove(struct i2c_client *client) { struct pca9685 *pca = i2c_get_clientdata(client); - int ret; - ret = pwmchip_remove(&pca->chip); - if (ret) - return ret; + pwmchip_remove(&pca->chip); if (!pm_runtime_enabled(&client->dev)) { /* Put chip in sleep state if runtime PM is disabled */