From: Geliang Tang <geliangtang@163.com>
Date: Thu, 1 Oct 2015 14:35:21 +0000 (+0800)
Subject: hsi: fix double kfree
X-Git-Tag: v5.15~14798^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f098a045350ecd6045f2f2d5a50fecf2a98962d7;p=platform%2Fkernel%2Flinux-starfive.git

hsi: fix double kfree

When device_register() fails, kfree() is called in hsi_client_release(),
hence there is no need to call kfree in err3 again.

Fixes: a2aa24734d9db ("HSI: Add common DT binding for HSI client devices")
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---

diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c
index fe93712..35d631e 100644
--- a/drivers/hsi/hsi.c
+++ b/drivers/hsi/hsi.c
@@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port,
 	if (device_register(&cl->device) < 0) {
 		pr_err("hsi: failed to register client: %s\n", name);
 		put_device(&cl->device);
-		goto err3;
 	}
 
 	return;