From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Mon, 18 Apr 2011 08:04:24 +0000 (+0200)
Subject: pad: Remove unnecessary FIXME
X-Git-Tag: RELEASE-0.10.36~332
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f07b637d86ef502305a7b8ed0ba7dd3844ef92cd;p=platform%2Fupstream%2Fgstreamer.git

pad: Remove unnecessary FIXME

Resetting the result is not necessary when resyncing because
pads that previously got the event will be skipped and we
need to consider the results of the previous pushes.
---

diff --git a/gst/gstpad.c b/gst/gstpad.c
index a599d42..6685094 100644
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -3570,8 +3570,9 @@ gst_pad_event_default_dispatch (GstPad * pad, GstEvent * event)
         gst_object_unref (item);
         break;
       case GST_ITERATOR_RESYNC:
-        /* FIXME, if we want to reset the result value we need to remember which
-         * pads pushed with which result */
+        /* We don't reset the result here because we don't push the event
+         * again on pads that got the event already and because we need
+         * to consider the result of the previous pushes */
         gst_iterator_resync (iter);
         break;
       case GST_ITERATOR_ERROR: