From: Keith Seitz Date: Mon, 30 Jul 2012 17:45:37 +0000 (+0000) Subject: * linespec.c (linespec_lex_number): A number followed X-Git-Tag: sid-snapshot-20120801~28 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eff9c3e636220ad8610d42d696a36a3a3f68dbfb;p=external%2Fbinutils.git * linespec.c (linespec_lex_number): A number followed by quotes is a valid number, too. * gdb.linespec/ls-errs.exp: Check some quote-enclosed linespecs. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 00411df..3bc3450 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2012-07-30 Keith Seitz + + * linespec.c (linespec_lex_number): A number followed + by quotes is a valid number, too. + 2012-07-30 Tom Tromey * remote-sim.c (gdb_os_poll_quit): Don't check immediate_quit. diff --git a/gdb/linespec.c b/gdb/linespec.c index 3d7f62f..51994c8 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -391,10 +391,11 @@ linespec_lexer_lex_number (linespec_parser *parser, linespec_token *tokenp) } /* If the next character in the input buffer is not a space, comma, - or colon, this input does not represent a number. */ + quote, or colon, this input does not represent a number. */ if (*PARSER_STREAM (parser) != '\0' && !isspace (*PARSER_STREAM (parser)) && *PARSER_STREAM (parser) != ',' - && *PARSER_STREAM (parser) != ':') + && *PARSER_STREAM (parser) != ':' + && !strchr (linespec_quote_characters, *PARSER_STREAM (parser))) { PARSER_STREAM (parser) = LS_TOKEN_STOKEN (*tokenp).ptr; return 0; diff --git a/gdb/testsuite/gdb.linespec/ls-errs.exp b/gdb/testsuite/gdb.linespec/ls-errs.exp index 7db8ae4..5668397 100644 --- a/gdb/testsuite/gdb.linespec/ls-errs.exp +++ b/gdb/testsuite/gdb.linespec/ls-errs.exp @@ -146,6 +146,8 @@ add the_tests "$srcfile:3 foo" unexpected_opt "string" "foo" foreach x $invalid_offsets { add the_tests "$srcfile:$x" invalid_offset_f $x $srcfile + add the_tests "\"$srcfile:$x\"" invalid_offset_f $x $srcfile + add the_tests "'$srcfile:$x'" invalid_offset_f $x $srcfile } # Test invalid filespecs starting with function.