From: Yang Tse <yangsita@gmail.com>
Date: Mon, 21 Jan 2013 20:21:30 +0000 (+0100)
Subject: xc-cc-check.m4: re-evaluate exporting and AC_SUBST'ing vars
X-Git-Tag: upstream/7.37.1~2301
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=efe46566566d9d651f297041f39c057de588b329;p=platform%2Fupstream%2Fcurl.git

xc-cc-check.m4: re-evaluate exporting and AC_SUBST'ing vars

Notes:

When running a configure script that has nested packages (for example
libcurl's configure with --enable-ares and c-ares sources embedded in
curl tree) and AC_CONFIG_SUBDIRS([nested-subdir]) machinery is used to
automatically run the nested configure script from within the parent
configure script, it happens that the nested _shell_ script will
inherit shell variables exported from the parent _shell_ script.

If for example parent configure script sets and exports LDFLAGS and LIBS
variables with proper values in order to link either a parent library or
program with a library which will be configured and built by a nested
package; It will happen that when the nested configure script runs, the
nested library does not exist yet and _any_ link-test done in the nested
configure will fail, such as those that autoconf macros perform in order
to detect existing compiler and its characteristics, the result is that
the nested configure script will fail with errors such as:

configure: error: C compiler cannot create executables

For now, we no longer export variables previously exported here.

On the other hand, AC_SUBST'ing them is appropriate and even with nested
packages each package's config.status gets its own package values.

So we reinstate AC_SUBST'ing previously AC_SUBST'ed variables.
---

diff --git a/m4/xc-cc-check.m4 b/m4/xc-cc-check.m4
index 286e798..cd55405 100644
--- a/m4/xc-cc-check.m4
+++ b/m4/xc-cc-check.m4
@@ -26,12 +26,6 @@ dnl -------------------------------------------------
 dnl Private macro.
 
 AC_DEFUN([_XC_PROG_CC_PREAMBLE], [
-dnl  export CC
-dnl  export CPP
-dnl  export LIBS
-dnl  export CFLAGS
-dnl  export LDFLAGS
-dnl  export CPPFLAGS
   xc_prog_cc_prev_IFS=$IFS
   xc_prog_cc_prev_LIBS=$LIBS
   xc_prog_cc_prev_CFLAGS=$CFLAGS
@@ -50,12 +44,12 @@ AC_DEFUN([_XC_PROG_CC_POSTLUDE], [
   CFLAGS=$xc_prog_cc_prev_CFLAGS
   LDFLAGS=$xc_prog_cc_prev_LDFLAGS
   CPPFLAGS=$xc_prog_cc_prev_CPPFLAGS
-dnl  AC_SUBST([CC])dnl
-dnl  AC_SUBST([CPP])dnl
-dnl  AC_SUBST([LIBS])dnl
-dnl  AC_SUBST([CFLAGS])dnl
-dnl  AC_SUBST([LDFLAGS])dnl
-dnl  AC_SUBST([CPPFLAGS])dnl
+  AC_SUBST([CC])dnl
+  AC_SUBST([CPP])dnl
+  AC_SUBST([LIBS])dnl
+  AC_SUBST([CFLAGS])dnl
+  AC_SUBST([LDFLAGS])dnl
+  AC_SUBST([CPPFLAGS])dnl
 ])