From: Ajay Singh Date: Mon, 2 Mar 2020 16:22:35 +0000 (+0000) Subject: staging: wilc1000: use correct data for memcpy in wilc_hif_pack_sta_param() X-Git-Tag: v5.15~4244^2~186 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=efabc44b8004b83cb91ed1242b9ce7622a91b0f5;p=platform%2Fkernel%2Flinux-starfive.git staging: wilc1000: use correct data for memcpy in wilc_hif_pack_sta_param() Use correct data for memcpy in wilc_hif_pack_sta_param(). Its reported by Smatch static code analyser tool as discussed in [1]. [1]. https://lore.kernel.org/linux-wireless/20200302092346.GA24308@kadam/ Suggested-by: Dan Carpenter Signed-off-by: Ajay Singh Link: https://lore.kernel.org/r/20200302162226.4196-2-ajay.kathat@microchip.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000/hif.c index c8c41c2..6c7de2f 100644 --- a/drivers/staging/wilc1000/hif.c +++ b/drivers/staging/wilc1000/hif.c @@ -801,7 +801,7 @@ static void wilc_hif_pack_sta_param(u8 *cur_byte, const u8 *mac, if (params->ht_capa) { *cur_byte++ = true; - memcpy(cur_byte, ¶ms->ht_capa, + memcpy(cur_byte, params->ht_capa, sizeof(struct ieee80211_ht_cap)); } else { *cur_byte++ = false;