From: Axel Lin Date: Thu, 8 Dec 2011 13:05:26 +0000 (+0800) Subject: jz4740-battery: Fix signedness bug X-Git-Tag: upstream/snapshot3+hdmi~8366^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ef7906f3204280ccaf8cd7ace974b7c0a1393812;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git jz4740-battery: Fix signedness bug wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned. Signed-off-by: Axel Lin Acked-by: Lars-Peter Clausen Signed-off-by: Anton Vorontsov --- diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c index 6b77029..8dbc7bf 100644 --- a/drivers/power/jz4740-battery.c +++ b/drivers/power/jz4740-battery.c @@ -67,7 +67,7 @@ static irqreturn_t jz_battery_irq_handler(int irq, void *devid) static long jz_battery_read_voltage(struct jz_battery *battery) { - unsigned long t; + long t; unsigned long val; long voltage;