From: Martin Xu Date: Tue, 9 Feb 2010 09:29:52 +0000 (+0100) Subject: Remove wrong unref of sevice->pending X-Git-Tag: accepted/2.0alpha-wayland/20121110.002834~2844 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ef65e9417606781bf4c33e63e9f16cca68b81737;p=profile%2Fivi%2Fconnman.git Remove wrong unref of sevice->pending When setting static ip for ethernet service, unreferencing service->pending here will cause a segmentation fault. The reason is that it is done in __connman_service_indicate_state() when connection succeeds, and service->pending is NULL. --- diff --git a/src/service.c b/src/service.c index eb1402a..8f52fc0 100644 --- a/src/service.c +++ b/src/service.c @@ -1062,9 +1062,6 @@ static DBusMessage *connect_service(DBusConnection *conn, return NULL; } - dbus_message_unref(service->pending); - service->pending = NULL; - return g_dbus_create_reply(msg, DBUS_TYPE_INVALID); }