From: Sangwan Kwon <sangwan.kwon@samsung.com>
Date: Tue, 14 Jan 2020 06:07:33 +0000 (+0900)
Subject: Fix compiler warnings
X-Git-Tag: submit/tizen/20200810.073515~98
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eec6374003efeba64c8ed89329d7b69c1ee74980;p=platform%2Fcore%2Fsecurity%2Fvist.git

Fix compiler warnings

Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
---

diff --git a/src/vist/CMakeLists.txt b/src/vist/CMakeLists.txt
index b9055a3..cc9addf 100644
--- a/src/vist/CMakeLists.txt
+++ b/src/vist/CMakeLists.txt
@@ -37,6 +37,12 @@ ADD_DEFINITIONS(-DDB_PATH="${DB_INSTALL_DIR}/.vist.db"
 				-DPLUGIN_INSTALL_DIR="${PLUGIN_INSTALL_DIR}"
 				-DSCRIPT_INSTALL_DIR="${SCRIPT_INSTALL_DIR}")
 
+ADD_DEFINITIONS("-Werror")
+ADD_DEFINITIONS("-Wall")
+ADD_DEFINITIONS("-Wextra")
+ADD_DEFINITIONS("-pedantic")
+ADD_DEFINITIONS("-pedantic-errors")
+
 # common
 ADD_SUBDIRECTORY(common)
 ADD_SUBDIRECTORY(database)
diff --git a/src/vist/archive.hpp b/src/vist/archive.hpp
index 7cd3ae8..422ec65 100644
--- a/src/vist/archive.hpp
+++ b/src/vist/archive.hpp
@@ -135,7 +135,7 @@ void Archive::transform(std::tuple<Ts...>& tuple)
 }
 
 template<typename T>
-void Archive::transformImpl(T& tuple, EmptySequence)
+void Archive::transformImpl(T&, EmptySequence)
 {
 }
 
diff --git a/src/vist/event/mainloop.hpp b/src/vist/event/mainloop.hpp
index c42ab24..a1b8ef0 100644
--- a/src/vist/event/mainloop.hpp
+++ b/src/vist/event/mainloop.hpp
@@ -75,7 +75,7 @@ private:
 	int epollFd;
 	std::atomic<bool> stopped;
 
-	const int MAX_EPOLL_EVENTS = 16;
+	constexpr static int MAX_EPOLL_EVENTS = 16;
 };
 
 } // namespace event
diff --git a/src/vist/klass/functor.hpp b/src/vist/klass/functor.hpp
index 6e61d4c..67be7b3 100644
--- a/src/vist/klass/functor.hpp
+++ b/src/vist/klass/functor.hpp
@@ -121,7 +121,7 @@ Archive Functor<R, K, Ps...>::dispatch(Archive& archive)
 
 template<typename R, typename K, typename... Ps>
 template<typename T>
-auto Functor<R, K, Ps...>::operator()(T& tuple,
+auto Functor<R, K, Ps...>::operator()(T&,
 									  EmptySequence) -> typename MemFunc::Return
 {
 	return (*this)();
diff --git a/src/vist/logger.hpp b/src/vist/logger.hpp
index d4fdb0c..137701e 100644
--- a/src/vist/logger.hpp
+++ b/src/vist/logger.hpp
@@ -184,7 +184,7 @@ private:
 
 #define LOG(level, tag) vist::LogStream(LOGCAT(vist::LogLevel::level, #tag))
 #define LOGCAT(level, tag) \
-	vist::LogRecord {level, tag, __FILENAME__, __LINE__, __func__}
+	vist::LogRecord {level, tag, __FILENAME__, __LINE__, __func__, ""}
 
 #define NULLSTREAM std::ostringstream()
 
diff --git a/src/vist/query-builder/crud.hpp b/src/vist/query-builder/crud.hpp
index 2ef2a14..bfba587 100644
--- a/src/vist/query-builder/crud.hpp
+++ b/src/vist/query-builder/crud.hpp
@@ -160,7 +160,7 @@ T& Crud<T>::update(ColumnTypes&&... cts)
 	ss << "UPDATE " << static_cast<T*>(this)->name << " ";
 	ss << "SET ";
 
-	int i = 0;
+	unsigned int i = 0;
 	for (const auto& c : columnNames) {
 		ss << c << " = ?";
 
diff --git a/src/vist/query-builder/type.hpp b/src/vist/query-builder/type.hpp
index 17882a5..36f802c 100644
--- a/src/vist/query-builder/type.hpp
+++ b/src/vist/query-builder/type.hpp
@@ -29,13 +29,13 @@ bool cast_compare(L l, R r)
 }
 
 template<typename L, typename R>
-bool compare(L l, R r)
+bool compare(L, R)
 {
 	return std::is_same<L, R>::value;
 }
 
 template<typename L, typename R>
-void assert_compare(L l, R r)
+void assert_compare(L, R)
 {
 	static_assert(std::is_same<L, R>::value, "Type is unsafe.");
 }
diff --git a/src/vist/rmi/impl/ondemand/mainloop.cpp b/src/vist/rmi/impl/ondemand/mainloop.cpp
index 7bc028e..613632b 100644
--- a/src/vist/rmi/impl/ondemand/mainloop.cpp
+++ b/src/vist/rmi/impl/ondemand/mainloop.cpp
@@ -93,7 +93,7 @@ Mainloop::Handler Mainloop::getHandler(const int fd)
 	return std::make_pair(iter->second.first, iter->second.second);
 }
 
-bool Mainloop::prepare(void)
+void Mainloop::prepare(void)
 {
 	auto wakeup = [this]() {
 		this->wakeupSignal.receive();
diff --git a/src/vist/rmi/impl/ondemand/mainloop.hpp b/src/vist/rmi/impl/ondemand/mainloop.hpp
index ae061b3..8ce748c 100644
--- a/src/vist/rmi/impl/ondemand/mainloop.hpp
+++ b/src/vist/rmi/impl/ondemand/mainloop.hpp
@@ -67,7 +67,7 @@ private:
 
 	Handler getHandler(const int fd);
 
-	bool prepare(void);
+	void prepare(void);
 
 	void wait(int timeout, Stopper stopper);
 	void dispatch(int size);
diff --git a/src/vist/sdk/tests/sdk.cpp b/src/vist/sdk/tests/sdk.cpp
index 1ccdd6a..a21ff8d 100644
--- a/src/vist/sdk/tests/sdk.cpp
+++ b/src/vist/sdk/tests/sdk.cpp
@@ -42,7 +42,7 @@ class TestPolicyModelFailed : public PolicyModel {
 public:
 	TestPolicyModelFailed() : PolicyModel("test_policy_failed", PolicyValue(1)) {}
 
-	virtual void onChanged(const PolicyValue& value)
+	virtual void onChanged(const PolicyValue&)
 	{
 		throw std::runtime_error("Intended exception for test.");
 	}