From: Axel Lin Date: Fri, 12 Jul 2013 08:15:15 +0000 (+0800) Subject: clk: sunxi: Fix checking return value of clk_register_[composite|factors] X-Git-Tag: accepted/tizen/common/20141203.182822~1515^2~66 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ee85e9bd25773a30002769c8121b6ae62f23f2b4;p=platform%2Fkernel%2Flinux-arm64.git clk: sunxi: Fix checking return value of clk_register_[composite|factors] clk_register_composite() and clk_register_factors() return ERR_PTR on error. Signed-off-by: Axel Lin Acked-by: Maxime Ripard Signed-off-by: Mike Turquette --- diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 412912b..02e440b 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -64,7 +64,7 @@ static void __init sunxi_osc_clk_setup(struct device_node *node) &gate->hw, &clk_gate_ops, CLK_IS_ROOT); - if (clk) { + if (!IS_ERR(clk)) { of_clk_add_provider(node, of_clk_src_simple_get, clk); clk_register_clkdev(clk, clk_name, NULL); } @@ -221,7 +221,7 @@ static void __init sunxi_factors_clk_setup(struct device_node *node, clk = clk_register_factors(NULL, clk_name, parent, 0, reg, data->table, data->getter, &clk_lock); - if (clk) { + if (!IS_ERR(clk)) { of_clk_add_provider(node, of_clk_src_simple_get, clk); clk_register_clkdev(clk, clk_name, NULL); }