From: Miaoqian Lin Date: Thu, 29 Dec 2022 06:29:25 +0000 (+0400) Subject: net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe X-Git-Tag: v6.1.8~469 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ee84d37a5f08ed1121cdd16f8f3ed87552087a21;p=platform%2Fkernel%2Flinux-starfive.git net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe [ Upstream commit d039535850ee47079d59527e96be18d8e0daa84b ] of_phy_find_device() return device node with refcount incremented. Call put_device() to relese it when not needed anymore. Fixes: ab4e6ee578e8 ("net: phy: xgmiitorgmii: Check phy_driver ready before accessing") Signed-off-by: Miaoqian Lin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c index 8dcb49e..7fd9fe6 100644 --- a/drivers/net/phy/xilinx_gmii2rgmii.c +++ b/drivers/net/phy/xilinx_gmii2rgmii.c @@ -105,6 +105,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev) if (!priv->phy_dev->drv) { dev_info(dev, "Attached phy not ready\n"); + put_device(&priv->phy_dev->mdio.dev); return -EPROBE_DEFER; }