From: Jim Meyering Date: Tue, 20 Mar 2012 18:21:01 +0000 (+0100) Subject: maint: use more modern fseeko, rather than fseek X-Git-Tag: v8.16~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ee7740c300f38205b114b6ae34ccf4c5aa4d9134;p=platform%2Fupstream%2Fcoreutils.git maint: use more modern fseeko, rather than fseek * src/tac.c (temp_stream): Use fseeko, not fseek, on principle: use the more modern interface. In general it is better to avoid fseek due to its ABI-imposed 4GiB limit on the "offset", here its use was fine because the offset was always 0. Using fseeko also has the advantage of not triggering a GNULIB_POSIXCHECK warning. Reported by Eric Blake in http://thread.gmane.org/gmane.comp.gnu.coreutils.general/2426/focus=2489 --- diff --git a/src/tac.c b/src/tac.c index 670b20d..b50382d 100644 --- a/src/tac.c +++ b/src/tac.c @@ -470,7 +470,7 @@ temp_stream (FILE **fp, char **file_name) } else { - if (fseek (tmp_fp, 0, SEEK_SET) < 0 + if (fseeko (tmp_fp, 0, SEEK_SET) < 0 || ftruncate (fileno (tmp_fp), 0) < 0) { error (0, errno, _("failed to rewind stream for %s"),