From: Thomas Zimmermann Date: Tue, 9 Feb 2021 13:46:24 +0000 (+0100) Subject: drm/ast: Fix invalid usage of AST_MAX_HWC_WIDTH in cursor atomic_check X-Git-Tag: v5.15~303^2~28^2~781 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ee4a92d690f30f3793df942939726bec0338e65b;p=platform%2Fkernel%2Flinux-starfive.git drm/ast: Fix invalid usage of AST_MAX_HWC_WIDTH in cursor atomic_check Use AST_MAX_HWC_HEIGHT for setting offset_y in the cursor plane's atomic_check. The code used AST_MAX_HWC_WIDTH instead. This worked because both constants has the same value. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Link: https://patchwork.freedesktop.org/patch/msgid/20210209134632.12157-3-tzimmermann@suse.de --- diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 988b270..758c69aa 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -688,7 +688,7 @@ ast_cursor_plane_helper_atomic_update(struct drm_plane *plane, unsigned int offset_x, offset_y; offset_x = AST_MAX_HWC_WIDTH - fb->width; - offset_y = AST_MAX_HWC_WIDTH - fb->height; + offset_y = AST_MAX_HWC_HEIGHT - fb->height; if (state->fb != old_state->fb) { /* A new cursor image was installed. */