From: Alan Cox <alan@linux.intel.com>
Date: Mon, 22 Feb 2016 04:07:27 +0000 (+0530)
Subject: ASoC: Intel: Skylake: remove bogus comparison of an array with NULL
X-Git-Tag: v4.14-rc1~3503^2~24^2~13^2~24
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=edd7ea2d5486c12978fdc71c6efd493cbabeea60;p=platform%2Fkernel%2Flinux-rpi.git

ASoC: Intel: Skylake: remove bogus comparison of an array with NULL

dfw_ac->params is an array not a pointer. It will never be NULL. The check
on ac->max appears sufficient.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index ba0d02d..c95bbce 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -1657,8 +1657,7 @@ static int skl_init_algo_data(struct device *dev, struct soc_bytes_ext *be,
 		if (!ac->params)
 			return -ENOMEM;
 
-		if (dfw_ac->params)
-			memcpy(ac->params, dfw_ac->params, ac->max);
+		memcpy(ac->params, dfw_ac->params, ac->max);
 	}
 
 	be->dobj.private  = ac;