From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 27 Jan 2016 18:02:10 +0000 (+0100)
Subject: sd-journal: minor optimization
X-Git-Tag: v231~686^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ed71f95662af903f0c5eba32c439e77c5cec4e7b;p=platform%2Fupstream%2Fsystemd.git

sd-journal: minor optimization

No need to store the object and offset data if we don't actually need it ever.
---

diff --git a/src/journal/sd-journal.c b/src/journal/sd-journal.c
index 85d9bbe..7a3aaf0 100644
--- a/src/journal/sd-journal.c
+++ b/src/journal/sd-journal.c
@@ -2520,24 +2520,20 @@ _public_ int sd_journal_enumerate_unique(sd_journal *j, const void **data, size_
                  * traversed files. */
                 found = false;
                 ORDERED_HASHMAP_FOREACH(of, j->files, i) {
-                        Object *oo;
-                        uint64_t op;
-
                         if (of == j->unique_file)
                                 break;
 
-                        /* Skip this file it didn't have any fields
-                         * indexed */
-                        if (JOURNAL_HEADER_CONTAINS(of->header, n_fields) &&
-                            le64toh(of->header->n_fields) <= 0)
+                        /* Skip this file it didn't have any fields indexed */
+                        if (JOURNAL_HEADER_CONTAINS(of->header, n_fields) && le64toh(of->header->n_fields) <= 0)
                                 continue;
 
-                        r = journal_file_find_data_object_with_hash(of, odata, ol, le64toh(o->data.hash), &oo, &op);
+                        r = journal_file_find_data_object_with_hash(of, odata, ol, le64toh(o->data.hash), NULL, NULL);
                         if (r < 0)
                                 return r;
-
-                        if (r > 0)
+                        if (r > 0) {
                                 found = true;
+                                break;
+                        }
                 }
 
                 if (found)