From: Jaechul Lee Date: Wed, 1 Feb 2017 02:22:48 +0000 (+0900) Subject: power: Removed unnecessary logs during booting and idle state. X-Git-Tag: submit/tizen/20170214.054550~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ed65a2eb6c1591e9b000d592d42653ec011538fb;p=profile%2Fwearable%2Fplatform%2Fkernel%2Flinux-3.18-exynos7270.git power: Removed unnecessary logs during booting and idle state. Changed levels of unnecessary log to debug from error and info. Moreover, changed error code to ENODATA from EINVAL to avoid printing out too much logs during idle state. Signed-off-by: Jaechul Lee --- diff --git a/drivers/battery/p9220_charger.c b/drivers/battery/p9220_charger.c index 3a0621b5109..bc3f878b261 100644 --- a/drivers/battery/p9220_charger.c +++ b/drivers/battery/p9220_charger.c @@ -1417,7 +1417,7 @@ static int p9220_chg_get_property(struct power_supply *psy, switch (psp) { case POWER_SUPPLY_PROP_STATUS: ret = p9220_get_firmware_version(charger, P9220_RX_FIRMWARE); - pr_info("%s rx major firmware version 0x%x \n", __func__, ret); + pr_debug("%s rx major firmware version 0x%x \n", __func__, ret); if (ret >= 0) val->intval = 1; @@ -1444,7 +1444,7 @@ static int p9220_chg_get_property(struct power_supply *psy, break; #if defined(CONFIG_WIRELESS_FIRMWARE_UPDATE) case POWER_SUPPLY_PROP_MANUFACTURER: - pr_info("%s POWER_SUPPLY_PROP_MANUFACTURER =%d \n ", __func__, val->intval); + pr_debug("%s POWER_SUPPLY_PROP_MANUFACTURER =%d \n ", __func__, val->intval); val->intval = 0; break; if (val->intval == SEC_WIRELESS_OTP_FIRM_RESULT) { @@ -1499,7 +1499,7 @@ static int p9220_chg_get_property(struct power_supply *psy, break; default: pr_debug("%s default================== =%d \n ", __func__, val->intval); - return -EINVAL; + return -ENODATA; } return 0; } diff --git a/drivers/battery/s2mpw01_charger.c b/drivers/battery/s2mpw01_charger.c index a12949b74f1..3458e6cb054 100644 --- a/drivers/battery/s2mpw01_charger.c +++ b/drivers/battery/s2mpw01_charger.c @@ -581,7 +581,7 @@ static int s2mpw01_get_charging_status(struct s2mpw01_charger_data *charger) ret = s2mpw01_read_reg(charger->client, S2MPW01_CHG_REG_STATUS1, &chg_sts); if (ret < 0) return status; - dev_info(charger->dev, "%s : charger status : 0x%x\n", __func__, chg_sts); + dev_dbg(charger->dev, "%s : charger status : 0x%x\n", __func__, chg_sts); if (charger->full_charged) { dev_info(charger->dev, "%s : POWER_SUPPLY_STATUS_FULL : 0x%x\n", __func__, chg_sts); @@ -653,14 +653,13 @@ static int s2mpw01_get_charging_health(struct s2mpw01_charger_data *charger) ret = s2mpw01_read_reg(charger->client, S2MPW01_CHG_REG_STATUS1, &data); s2mpw01_read_reg(charger->iodev->pmic, S2MPW01_PMIC_REG_STATUS1, &data1); - pr_info("[%s] chg_status1: 0x%x, pm_status1: 0x%x\n " , __func__, data, data1); + pr_debug("[%s] chg_status1: 0x%x, pm_status1: 0x%x\n " , __func__, data, data1); if (ret < 0) return POWER_SUPPLY_HEALTH_UNKNOWN; if (data & (1 << CHG_STATUS1_CHGVIN)) { charger->ovp = false; charger->unhealth_cnt = 0; - pr_info("[%s] POWER_SUPPLY_HEALTH_GOOD\n " , __func__); return POWER_SUPPLY_HEALTH_GOOD; } @@ -731,7 +730,7 @@ static int s2mpw01_chg_get_property(struct power_supply *psy, val->intval = charger->tx_type; break; default: - return -EINVAL; + return -ENODATA; } return 0; diff --git a/drivers/battery/s2mpw01_fuelgauge.c b/drivers/battery/s2mpw01_fuelgauge.c index 4f72c1776a9..d85ef790bd7 100644 --- a/drivers/battery/s2mpw01_fuelgauge.c +++ b/drivers/battery/s2mpw01_fuelgauge.c @@ -156,7 +156,7 @@ static void s2mpw01_fg_test_read(struct i2c_client *i2c) s2mpw01_fg_read_reg_byte(i2c, 0x23, &data); sprintf(str+strlen(str), "ADCMX_0x23 :0x%02x, ", data); - pr_err("[DEBUG]%s: %s\n", __func__, str); + pr_debug("[DEBUG]%s: %s\n", __func__, str); } static void s2mpw01_restart_gauging(struct s2mpw01_fuelgauge_data *fuelgauge) @@ -408,7 +408,7 @@ static int s2mpw01_get_current(struct s2mpw01_fuelgauge_data *fuelgauge) curr = (curr * (-1000)) >> 12; } - dev_info(&fuelgauge->i2c->dev, "%s: current (%d)mA\n", __func__, curr); + dev_dbg(&fuelgauge->i2c->dev, "%s: current (%d)mA\n", __func__, curr); return curr; } @@ -449,7 +449,7 @@ static int s2mpw01_get_vbat(struct s2mpw01_fuelgauge_data *fuelgauge) pr_err("%s: 0x46 read error\n", __func__); return ret; } - dev_info(&fuelgauge->i2c->dev, "%s: 0x46: (0x%x)\n", __func__, val); + dev_dbg(&fuelgauge->i2c->dev, "%s: 0x46: (0x%x)\n", __func__, val); return vbat; } @@ -472,7 +472,7 @@ static int s2mpw01_get_avgvbat(struct s2mpw01_fuelgauge_data *fuelgauge) old_vbat = new_vbat / 2 + old_vbat / 2; } - dev_info(&fuelgauge->i2c->dev, "%s: avgvbat (%d)\n", __func__, old_vbat); + dev_dbg(&fuelgauge->i2c->dev, "%s: avgvbat (%d)\n", __func__, old_vbat); return old_vbat; } @@ -573,7 +573,7 @@ static void s2mpw01_fg_get_scaled_capacity( 0 : ((val->intval - fuelgauge->pdata->capacity_min) * 1000 / (fuelgauge->capacity_max - fuelgauge->pdata->capacity_min)); - dev_err(fuelgauge->dev, "%s: scaled capacity (%d.%d)\n", + dev_dbg(fuelgauge->dev, "%s: scaled capacity (%d.%d)\n", __func__, val->intval/10, val->intval%10); } @@ -745,8 +745,6 @@ static int s2mpw01_fg_get_property(struct power_supply *psy, struct s2mpw01_fuelgauge_data *fuelgauge = container_of(psy, struct s2mpw01_fuelgauge_data, psy_fg); - pr_info("%s %d psp=%d\n",__FUNCTION__, __LINE__ ,psp); - switch (psp) { case POWER_SUPPLY_PROP_STATUS: case POWER_SUPPLY_PROP_CHARGE_FULL: @@ -840,7 +838,7 @@ static int s2mpw01_fg_get_property(struct power_supply *psy, val->intval = fuelgauge->capacity_max; break; default: - return -EINVAL; + return -ENODATA; } return 0;