From: Dan Carpenter Date: Tue, 27 Aug 2013 01:19:42 +0000 (+0300) Subject: ab8500-charger: We print an unintended error message X-Git-Tag: upstream/snapshot3+hdmi~4348^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ed5243f8ab2470e988dce0e416eaaddb4d7d2ccc;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ab8500-charger: We print an unintended error message There is a missing break statement here, so we print an error message that the USB type is invalid. The original code still works fine though except for the error message. Signed-off-by: Dan Carpenter Signed-off-by: Anton Vorontsov --- diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c index f098fda..a4c4a10 100644 --- a/drivers/power/ab8500_charger.c +++ b/drivers/power/ab8500_charger.c @@ -774,6 +774,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di, di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P5; dev_dbg(di->dev, "USB Type - 0x%02x MaxCurr: %d", link_status, di->max_usb_in_curr.usb_type_max); + break; case USB_STAT_NOT_VALID_LINK: dev_err(di->dev, "USB Type invalid - try charging anyway\n"); di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P5;