From: Nathan Chancellor Date: Tue, 7 Apr 2020 03:09:27 +0000 (-0700) Subject: kernel/extable.c: use address-of operator on section symbols X-Git-Tag: accepted/tizen/unified/20230531.034423~34 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ed0d0e04a0e2bd2ac3531fad05eaa4f91995c1ef;p=platform%2Fkernel%2Flinux-amlogic.git kernel/extable.c: use address-of operator on section symbols Clang warns: ../kernel/extable.c:37:52: warning: array comparison always evaluates to a constant [-Wtautological-compare] if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) { ^ 1 warning generated. These are not true arrays, they are linker defined symbols, which are just addresses. Using the address of operator silences the warning and does not change the resulting assembly with either clang/ld.lld or gcc/ld (tested with diff + objdump -Dr). Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor Signed-off-by: Andrew Morton Reviewed-by: Andrew Morton Link: https://github.com/ClangBuiltLinux/linux/issues/892 Link: http://lkml.kernel.org/r/20200219202036.45702-1-natechancellor@gmail.com Signed-off-by: Linus Torvalds [sw0312.kim: cherry-pick upstream commit 63174f61dfae to resolve gcc-12 build issue] Signed-off-by: Seung-Woo Kim Change-Id: Iead005392ebb5b2b334a7eae324883cc5f75c2cc --- diff --git a/kernel/extable.c b/kernel/extable.c index 4f06fc3..daa4628 100644 --- a/kernel/extable.c +++ b/kernel/extable.c @@ -41,7 +41,8 @@ u32 __initdata __visible main_extable_sort_needed = 1; /* Sort the kernel's built-in exception table */ void __init sort_main_extable(void) { - if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) { + if (main_extable_sort_needed && + &__stop___ex_table > &__start___ex_table) { pr_notice("Sorting __ex_table...\n"); sort_extable(__start___ex_table, __stop___ex_table); }