From: Dan Williams Date: Wed, 21 Sep 2016 16:22:33 +0000 (-0700) Subject: libnvdimm: fix devm_nvdimm_memremap() error path X-Git-Tag: v4.14-rc1~2292^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ecfb6d8a041cc2ca80bc69ffc20c00067d190df5;p=platform%2Fkernel%2Flinux-rpi.git libnvdimm: fix devm_nvdimm_memremap() error path The internal alloc_nvdimm_map() helper might fail, particularly if the memory region is already busy. Report request_mem_region() failures and check for the failure. Reported-by: Ryan Chen Signed-off-by: Dan Williams --- diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c index 715583f..4d7bbd2 100644 --- a/drivers/nvdimm/core.c +++ b/drivers/nvdimm/core.c @@ -99,8 +99,11 @@ static struct nvdimm_map *alloc_nvdimm_map(struct device *dev, nvdimm_map->size = size; kref_init(&nvdimm_map->kref); - if (!request_mem_region(offset, size, dev_name(&nvdimm_bus->dev))) + if (!request_mem_region(offset, size, dev_name(&nvdimm_bus->dev))) { + dev_err(&nvdimm_bus->dev, "failed to request %pa + %zd for %s\n", + &offset, size, dev_name(dev)); goto err_request_region; + } if (flags) nvdimm_map->mem = memremap(offset, size, flags); @@ -171,6 +174,9 @@ void *devm_nvdimm_memremap(struct device *dev, resource_size_t offset, kref_get(&nvdimm_map->kref); nvdimm_bus_unlock(dev); + if (!nvdimm_map) + return NULL; + if (devm_add_action_or_reset(dev, nvdimm_map_put, nvdimm_map)) return NULL;