From: akallabeth <akallabeth@posteo.net>
Date: Tue, 19 May 2020 12:07:15 +0000 (+0200)
Subject: Fixed some more resource cleanup leaks in nla
X-Git-Tag: 2.1.1^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ece877b515f1f7f3800fac9bcfdbdf0ee56f3ce3;p=platform%2Fupstream%2Ffreerdp.git

Fixed some more resource cleanup leaks in nla

(cherry picked from commit 354bb7d6ae98df282775d154b609a39c1068a09b)
---

diff --git a/libfreerdp/core/nla.c b/libfreerdp/core/nla.c
index f354e04..63d77ab 100644
--- a/libfreerdp/core/nla.c
+++ b/libfreerdp/core/nla.c
@@ -1144,6 +1144,7 @@ SECURITY_STATUS nla_encrypt_public_key_echo(rdpNla* nla)
 	const BOOL ntlm = (_tcsncmp(nla->packageName, NTLM_SSP_NAME, ARRAYSIZE(NTLM_SSP_NAME)) == 0);
 	public_key_length = nla->PublicKey.cbBuffer;
 
+	sspi_SecBufferFree(&nla->pubKeyAuth);
 	if (!sspi_SecBufferAlloc(&nla->pubKeyAuth,
 	                         public_key_length + nla->ContextSizes.cbSecurityTrailer))
 		return SEC_E_INSUFFICIENT_MEMORY;
@@ -2465,6 +2466,7 @@ void nla_free(rdpNla* nla)
 	sspi_SecBufferFree(&nla->tsCredentials);
 	free(nla->ServicePrincipalName);
 	nla_identity_free(nla->identity);
+	nla_buffer_free(nla);
 	free(nla);
 }