From: Jonathan Cameron Date: Sun, 13 Jun 2021 15:23:00 +0000 (+0100) Subject: iio: light: vcnl4035: Fix buffer alignment in iio_push_to_buffers_with_timestamp() X-Git-Tag: accepted/tizen/unified/20230118.172025~6889^2~85^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ec90b52c07c0403a6db60d752484ec08d605ead0;p=platform%2Fkernel%2Flinux-rpi.git iio: light: vcnl4035: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Add __aligned(8) to ensure the buffer passed to iio_push_to_buffers_with_timestamp() is suitable for the naturally aligned timestamp that will be inserted. Here an explicit structure is not used, because the holes would necessitate the addition of an explict memset(), to avoid a potential kernel data leak, making for a less minimal fix. Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035") Signed-off-by: Jonathan Cameron Cc: Parthiban Nallathambi Reviewed-by: Nuno Sá Link: https://lore.kernel.org/r/20210613152301.571002-8-jic23@kernel.org --- diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c index fd2f181..0db306e 100644 --- a/drivers/iio/light/vcnl4035.c +++ b/drivers/iio/light/vcnl4035.c @@ -102,7 +102,8 @@ static irqreturn_t vcnl4035_trigger_consumer_handler(int irq, void *p) struct iio_poll_func *pf = p; struct iio_dev *indio_dev = pf->indio_dev; struct vcnl4035_data *data = iio_priv(indio_dev); - u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)]; + /* Ensure naturally aligned timestamp */ + u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)] __aligned(8); int ret; ret = regmap_read(data->regmap, VCNL4035_ALS_DATA, (int *)buffer);