From: Mark Brown Date: Mon, 19 Mar 2012 14:56:39 +0000 (+0000) Subject: OMAPDSS: VENC: Check for errors from regulator_enable() X-Git-Tag: v3.5-rc3~26^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ec8741078d0a644d68827c8a347ac6be153622b5;p=profile%2Fcommon%2Fkernel-common.git OMAPDSS: VENC: Check for errors from regulator_enable() It is possible for regulator_enable() to fail and if it does fail that's generally a bad sign for anything we try to do with the hardware afterwards so check for and immediately return an error if regulator_enable() fails. Signed-off-by: Mark Brown Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c index 9c3daf7..abfbd4a 100644 --- a/drivers/video/omap2/dss/venc.c +++ b/drivers/video/omap2/dss/venc.c @@ -443,7 +443,9 @@ static int venc_power_on(struct omap_dss_device *dssdev) dispc_set_digit_size(dssdev->panel.timings.x_res, dssdev->panel.timings.y_res/2); - regulator_enable(venc.vdda_dac_reg); + r = regulator_enable(venc.vdda_dac_reg); + if (r) + goto err; if (dssdev->platform_enable) dssdev->platform_enable(dssdev);