From: Matthias Clasen <mclasen@redhat.com>
Date: Sun, 30 Sep 2012 23:24:13 +0000 (-0400)
Subject: Really fix the leak
X-Git-Tag: 2.34.1~9
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ec82f610655f09bda21e9da1ce629762f72570df;p=platform%2Fupstream%2Fglib.git

Really fix the leak

Pointed out by Josselin Mouette.
---

diff --git a/gio/glib-compile-resources.c b/gio/glib-compile-resources.c
index c712010..ff97c67 100644
--- a/gio/glib-compile-resources.c
+++ b/gio/glib-compile-resources.c
@@ -325,7 +325,6 @@ end_element (GMarkupParseContext  *context,
                                  G_SPAWN_STDOUT_TO_DEV_NULL,
                                  NULL, NULL, NULL, &stderr_child, &status, &my_error))
                 {
-                  g_free (stderr_child);
                   g_propagate_error (error, my_error);
                   goto cleanup;
                 }
@@ -339,6 +338,7 @@ end_element (GMarkupParseContext  *context,
                   goto cleanup;
                 }
 
+              g_free (stderr_child);
               g_free (real_file);
               real_file = g_strdup (tmp_file);
             }
@@ -383,7 +383,6 @@ end_element (GMarkupParseContext  *context,
                                  NULL, NULL, NULL, &stderr_child, &status, &my_error))
                 {
                   g_propagate_error (error, my_error);
-                  g_free (stderr_child);
                   goto cleanup;
                 }
 	      
@@ -395,6 +394,7 @@ end_element (GMarkupParseContext  *context,
                   goto cleanup;
                 }
 
+              g_free (stderr_child);
               g_free (real_file);
               real_file = g_strdup (tmp_file2);
             }