From: Thiep Ha <thiepha@gmail.com>
Date: Wed, 14 Dec 2016 08:59:40 +0000 (+0900)
Subject: edje_calc: remove redundant checking
X-Git-Tag: accepted/tizen/common/20170102.152350~151
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ec37e36e18a7cd3112b20c733219a9a3324f2210;p=platform%2Fupstream%2Fefl.git

edje_calc: remove redundant checking

We check amin > ZERO && amax > ZERO, so no need to do it them again.

Change-Id: I0ef4f2ca56f14b5356182f4e94b10bd5bb704654
---

diff --git a/src/lib/edje/edje_calc.c b/src/lib/edje/edje_calc.c
index 124c4b7..3e17e23 100644
--- a/src/lib/edje/edje_calc.c
+++ b/src/lib/edje/edje_calc.c
@@ -1262,23 +1262,23 @@ _edje_part_recalc_single_aspect(Edje *ed,
            case EDJE_ASPECT_PREFER_NONE:
              /* keep both dimensions in check */
              /* adjust for min aspect (width / height) */
-             if ((amin > ZERO) && (aspect < amin))
+             if (aspect < amin)
                {
                   new_h = DIV(params->eval.w, amin);
                   new_w = MUL(amin, params->eval.h);
                }
              /* adjust for max aspect (width / height) */
-             if ((amax > ZERO) && (aspect > amax))
+             if (aspect > amax)
                {
                   new_h = DIV(params->eval.w, amax);
                   new_w = MUL(amax, params->eval.h);
                }
-             if ((amax > ZERO) && (new_w < params->eval.w))
+             if (new_w < params->eval.w)
                {
                   new_w = params->eval.w;
                   new_h = DIV(params->eval.w, amax);
                }
-             if ((amax > ZERO) && (new_h < params->eval.h))
+             if (new_h < params->eval.h)
                {
                   new_w = MUL(amax, params->eval.h);
                   new_h = params->eval.h;
@@ -1289,10 +1289,10 @@ _edje_part_recalc_single_aspect(Edje *ed,
            case  EDJE_ASPECT_PREFER_VERTICAL:
              /* keep both dimensions in check */
              /* adjust for max aspect (width / height) */
-             if ((amax > ZERO) && (aspect > amax))
+             if (aspect > amax)
                new_w = MUL(amax, params->eval.h);
              /* adjust for min aspect (width / height) */
-             if ((amin > ZERO) && (aspect < amin))
+             if (aspect < amin)
                new_w = MUL(amin, params->eval.h);
              break;
 
@@ -1300,10 +1300,10 @@ _edje_part_recalc_single_aspect(Edje *ed,
            case EDJE_ASPECT_PREFER_HORIZONTAL:
              /* keep both dimensions in check */
              /* adjust for max aspect (width / height) */
-             if ((amax > ZERO) && (aspect > amax))
+             if (aspect > amax)
                new_h = DIV(params->eval.w, amax);
              /* adjust for min aspect (width / height) */
-             if ((amin > ZERO) && (aspect < amin))
+             if (aspect < amin)
                new_h = DIV(params->eval.w, amin);
              break;
 
@@ -1311,13 +1311,13 @@ _edje_part_recalc_single_aspect(Edje *ed,
            case EDJE_ASPECT_PREFER_BOTH:
              /* keep both dimensions in check */
              /* adjust for max aspect (width / height) */
-             if ((amax > ZERO) && (aspect > amax))
+             if (aspect > amax)
                {
                   new_w = MUL(amax, params->eval.h);
                   new_h = DIV(params->eval.w, amax);
                }
              /* adjust for min aspect (width / height) */
-             if ((amin > ZERO) && (aspect < amin))
+             if (aspect < amin)
                {
                   new_w = MUL(amin, params->eval.h);
                   new_h = DIV(params->eval.w, amin);
@@ -1328,8 +1328,7 @@ _edje_part_recalc_single_aspect(Edje *ed,
              break;
           }
 
-        if (!((amin > ZERO) && (amax > ZERO) &&
-              (apref == EDJE_ASPECT_PREFER_NONE)))
+        if (apref != EDJE_ASPECT_PREFER_NONE)
           {
              if ((*maxw >= 0) && (new_w > FROM_INT(*maxw)))
                new_w = FROM_INT(*maxw);
@@ -1345,38 +1344,34 @@ _edje_part_recalc_single_aspect(Edje *ed,
         /* do real adjustment */
         if (apref == EDJE_ASPECT_PREFER_BOTH)
           {
-             if (amin == ZERO) amin = amax;
-             if (amin != ZERO)
+             /* fix h and vary w */
+             if (new_w > params->eval.w)
                {
-                  /* fix h and vary w */
+                  //		  params->w = new_w;
+                  // EXCEEDS BOUNDS in W
+                  new_h = DIV(params->eval.w, amin);
+                  new_w = params->eval.w;
+                  if (new_h > params->eval.h)
+                    {
+                       new_h = params->eval.h;
+                       new_w = MUL(amin, params->eval.h);
+                    }
+               }
+             /* fix w and vary h */
+             else
+               {
+                  //		  params->h = new_h;
+                  // EXCEEDS BOUNDS in H
+                  new_h = params->eval.h;
+                  new_w = MUL(amin, params->eval.h);
                   if (new_w > params->eval.w)
                     {
-                       //		  params->w = new_w;
-                       // EXCEEDS BOUNDS in W
                        new_h = DIV(params->eval.w, amin);
                        new_w = params->eval.w;
-                       if (new_h > params->eval.h)
-                         {
-                            new_h = params->eval.h;
-                            new_w = MUL(amin, params->eval.h);
-                         }
                     }
-                  /* fix w and vary h */
-                  else
-                    {
-                       //		  params->h = new_h;
-                       // EXCEEDS BOUNDS in H
-                       new_h = params->eval.h;
-                       new_w = MUL(amin, params->eval.h);
-                       if (new_w > params->eval.w)
-                         {
-                            new_h = DIV(params->eval.w, amin);
-                            new_w = params->eval.w;
-                         }
-                    }
-                  params->eval.w = new_w;
-                  params->eval.h = new_h;
                }
+             params->eval.w = new_w;
+             params->eval.h = new_h;
           }
      }
    if (apref != EDJE_ASPECT_PREFER_BOTH)