From: John Johansen Date: Mon, 11 Apr 2016 23:57:19 +0000 (-0700) Subject: apparmor: fix replacement bug that adds new child to old parent X-Git-Tag: v4.14-rc1~2771^2~30 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ec34fa24a934f4c8fd68f39b84abf34c42e5b06a;p=platform%2Fkernel%2Flinux-rpi.git apparmor: fix replacement bug that adds new child to old parent When set atomic replacement is used and the parent is updated before the child, and the child did not exist in the old parent so there is no direct replacement then the new child is incorrectly added to the old parent. This results in the new parent not having the child(ren) that it should and the old parent when being destroyed asserting the following error. AppArmor: policy_destroy: internal error, policy '' still contains profiles Signed-off-by: John Johansen Acked-by: Seth Arnold --- diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c index 222052f..c92a9f6 100644 --- a/security/apparmor/policy.c +++ b/security/apparmor/policy.c @@ -1193,7 +1193,7 @@ ssize_t aa_replace_profiles(void *udata, size_t size, bool noreplace) /* aafs interface uses replacedby */ rcu_assign_pointer(ent->new->replacedby->profile, aa_get_profile(ent->new)); - __list_add_profile(&parent->base.profiles, ent->new); + __list_add_profile(&newest->base.profiles, ent->new); aa_put_profile(newest); } else { /* aafs interface uses replacedby */