From: Sangchul Lee <sc11.lee@samsung.com>
Date: Thu, 4 Apr 2013 09:09:02 +0000 (+0900)
Subject: Corrected invalid return values of audio effect APIs
X-Git-Tag: submit/tizen_2.1/20130424.232047~3^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ebd43eaed507b32eb66809351347a349b7ad93f2;p=platform%2Fcore%2Fmultimedia%2Flibmm-player.git

Corrected invalid return values of audio effect APIs

Change-Id: If45ad969bb960cec374a3c3d5643e6572315ae5e
---

diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec
index 687383e..6805ba4 100644
--- a/packaging/libmm-player.spec
+++ b/packaging/libmm-player.spec
@@ -1,6 +1,6 @@
 Name:       libmm-player
 Summary:    Multimedia Framework Player Library
-Version:    0.2.16
+Version:    0.2.17
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0
diff --git a/src/mm_player_audioeffect.c b/src/mm_player_audioeffect.c
index 6141118..8fea055 100644
--- a/src/mm_player_audioeffect.c
+++ b/src/mm_player_audioeffect.c
@@ -832,13 +832,11 @@ mm_player_audio_effect_custom_get_eq_bands_width(MMHandleType hplayer, int band_
 		return MM_ERROR_PLAYER_SOUND_EFFECT_NOT_SUPPORTED_FILTER;
 	}
 
-	return_val_if_fail( player->pipeline, MM_ERROR_PLAYER_NOT_INITIALIZED );
-
 	eq_num = PLAYER_INI()->audio_effect_custom_eq_band_num;
 	if (band_idx < 0 || band_idx > eq_num-1)
 	{
 		debug_error("out of range, invalid band_idx(%d)", band_idx);
-		result = MM_ERROR_PLAYER_INTERNAL;
+		result = MM_ERROR_INVALID_ARGUMENT;
 	}
 	else
 	{
@@ -871,13 +869,11 @@ mm_player_audio_effect_custom_get_eq_bands_freq(MMHandleType hplayer, int band_i
 		return MM_ERROR_PLAYER_SOUND_EFFECT_NOT_SUPPORTED_FILTER;
 	}
 
-	return_val_if_fail( player->pipeline, MM_ERROR_PLAYER_NOT_INITIALIZED );
-
 	eq_num = PLAYER_INI()->audio_effect_custom_eq_band_num;
 	if (band_idx < 0 || band_idx > eq_num-1)
 	{
 		debug_error("out of range, invalid band_idx(%d)", band_idx);
-		result = MM_ERROR_PLAYER_INTERNAL;
+		result = MM_ERROR_INVALID_ARGUMENT;
 	}
 	else
 	{