From: Eunhae Choi Date: Mon, 21 Sep 2015 05:58:46 +0000 (+0900) Subject: inputselector: Fix buffer leak in sync_streams & cache_buffers mode X-Git-Tag: 1.6.1~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ebd2748cd0d6b2e0b35c1d87b7170dfe673ec917;p=platform%2Fupstream%2Fgstreamer.git inputselector: Fix buffer leak in sync_streams & cache_buffers mode After doing gst_pad_push() in case of sync_streams and cache_buffers, if the buffer can not be kept in cache, it should be unreffed to avoid memory leackage. https://bugzilla.gnome.org/show_bug.cgi?id=755141 --- diff --git a/plugins/elements/gstinputselector.c b/plugins/elements/gstinputselector.c index aa5cad3..6eecfa0 100644 --- a/plugins/elements/gstinputselector.c +++ b/plugins/elements/gstinputselector.c @@ -376,6 +376,7 @@ gst_selector_pad_cache_buffer (GstSelectorPad * selpad, GstBuffer * buffer) if (selpad->segment.format != GST_FORMAT_TIME) { GST_DEBUG_OBJECT (selpad, "Buffer %p with segment not in time format, " "not caching", buffer); + gst_buffer_unref (buffer); return; }