From: Colin Ian King Date: Thu, 3 Jun 2021 21:56:57 +0000 (+0100) Subject: netdevsim: Fix unsigned being compared to less than zero X-Git-Tag: accepted/tizen/unified/20230118.172025~6942^2~340 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ebbf5fcb94a7f3499747b282420a1c5f7e8d1c6f;p=platform%2Fkernel%2Flinux-rpi.git netdevsim: Fix unsigned being compared to less than zero The comparison of len < 0 is always false because len is a size_t. Fix this by making len a ssize_t instead. Addresses-Coverity: ("Unsigned compared against 0") Fixes: d395381909a3 ("netdevsim: Add max_vfs to bus_dev") Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index b56003d..ccec299 100644 --- a/drivers/net/netdevsim/bus.c +++ b/drivers/net/netdevsim/bus.c @@ -111,7 +111,7 @@ ssize_t nsim_bus_dev_max_vfs_read(struct file *file, { struct nsim_bus_dev *nsim_bus_dev = file->private_data; char buf[11]; - size_t len; + ssize_t len; len = snprintf(buf, sizeof(buf), "%u\n", nsim_bus_dev->max_vfs); if (len < 0)