From: Heinrich Schuchardt Date: Mon, 11 Jul 2022 17:40:13 +0000 (+0200) Subject: net: phy: possible NULL dereference in fixed_phy_create() X-Git-Tag: v2022.10~56^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ebb8ff61ad97bd1c9721b049497ddb80030eeb0f;p=platform%2Fkernel%2Fu-boot.git net: phy: possible NULL dereference in fixed_phy_create() We check if phydev is NULL. Only but if it is non-NULL we set one component of phydev. But even if it is NULL we set another. We should not dereference NULL in either case. Fixes: e24b58f5ed4f ("net: phy: don't require PHY interface mode during PHY creation") Signed-off-by: Heinrich Schuchardt Reviewed-by: Marek Behún --- diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index e6e1755..0350afd 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -984,10 +984,10 @@ struct phy_device *fixed_phy_create(ofnode node) } phydev = phy_device_create(NULL, 0, PHY_FIXED_ID, false); - if (phydev) + if (phydev) { phydev->node = subnode; - - phydev->interface = ofnode_read_phy_mode(node); + phydev->interface = ofnode_read_phy_mode(node); + } return phydev; }