From: Dan Carpenter Date: Tue, 17 Nov 2020 07:21:37 +0000 (+0300) Subject: drm/kmb: Remove an unnecessary NULL check X-Git-Tag: accepted/tizen/unified/20230118.172025~6402^2~28^2~1284 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eba0d703b3ca5f1f24df3798c936906f2da39058;p=platform%2Fkernel%2Flinux-rpi.git drm/kmb: Remove an unnecessary NULL check The NULL checking isn't done consistently in this function and it leads to a static checker warning: drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend() error: we previously assumed 'drm' could be null (see line 559) Fortunately "drm" cannot be NULL at this point so the check can just be removed. Signed-off-by: Dan Carpenter Reviewed-by: Anitha Chrisanthus Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20201117072137.GB1111239@mwanda --- diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index a31a840..66df3aa 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -556,7 +556,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match); static int __maybe_unused kmb_pm_suspend(struct device *dev) { struct drm_device *drm = dev_get_drvdata(dev); - struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL; + struct kmb_drm_private *kmb = to_kmb(drm); drm_kms_helper_poll_disable(drm);