From: Stefan Sauer Date: Mon, 2 Oct 2017 14:22:00 +0000 (+0200) Subject: structure: add a todo comment X-Git-Tag: 1.16.2~656 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eb329eec1ca2ecc9119e6cee7c338832770d1f72;p=platform%2Fupstream%2Fgstreamer.git structure: add a todo comment Printing NULL is confusing when the type is e.g. a GArray that is not empty. --- diff --git a/gst/gststructure.c b/gst/gststructure.c index 8596c2b..068b4fa 100644 --- a/gst/gststructure.c +++ b/gst/gststructure.c @@ -1829,6 +1829,7 @@ priv_gst_structure_append_to_gstring (const GstStructure * structure, GST_WARNING ("No value transform to serialize field '%s' of type '%s'", g_quark_to_string (field->name), _priv_gst_value_gtype_to_abbr (type)); + /* TODO(ensonic): don't print NULL if field->value is not empty */ g_string_append (s, "NULL"); } }