From: Coly Li Date: Sat, 11 Aug 2018 05:20:00 +0000 (+0800) Subject: bcache: add the missing comments for smp_mb()/smp_wmb() X-Git-Tag: v5.15~8146^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eb2b3d034511f7f5f5fa781b9354ea4d5dbd4fc5;p=platform%2Fkernel%2Flinux-starfive.git bcache: add the missing comments for smp_mb()/smp_wmb() Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb() without code comment. This patch adds the missing code comments for these memory barrier calls. Signed-off-by: Coly Li Reviewed-by: Shenghui Wang Signed-off-by: Jens Axboe --- diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h index 7f3594c..eca0d496 100644 --- a/drivers/md/bcache/closure.h +++ b/drivers/md/bcache/closure.h @@ -289,10 +289,12 @@ static inline void closure_init_stack(struct closure *cl) } /** - * closure_wake_up - wake up all closures on a wait list. + * closure_wake_up - wake up all closures on a wait list, + * with memory barrier */ static inline void closure_wake_up(struct closure_waitlist *list) { + /* Memory barrier for the wait list */ smp_mb(); __closure_wake_up(list); } diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e637d74..94c756c 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1136,11 +1136,11 @@ int bch_cached_dev_attach(struct cached_dev *dc, struct cache_set *c, list_move(&dc->list, &c->cached_devs); calc_cached_dev_sectors(c); - smp_wmb(); /* * dc->c must be set before dc->count != 0 - paired with the mb in * cached_dev_get() */ + smp_wmb(); refcount_set(&dc->count, 1); /* Block writeback thread, but spawn it */