From: cookie <cookie@samsung.com>
Date: Fri, 11 Aug 2017 05:08:59 +0000 (+0000)
Subject: Fix the PVS V547, V690
X-Git-Tag: submit/tizen/20190531.071250~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=eaeb28f6edb799ef9f2b80f6d53ffd294ae4b084;p=profile%2Fcommon%2Fapps%2Fweb%2Fbrowser.git

Fix the PVS V547, V690

[ Problem ]Expression '!urlPair' is always false.
[ Soluction] Fix the issue

Change-Id: Id67e918da6a52abb127c6a77b1017ee39c65c1ef
Signed-off-by: cookie <cookie@samsung.com>
---

diff --git a/core/Tools/BrowserImage.cpp b/core/Tools/BrowserImage.cpp
old mode 100644
new mode 100755
index df9f027a..1d34c2c8
--- a/core/Tools/BrowserImage.cpp
+++ b/core/Tools/BrowserImage.cpp
@@ -77,7 +77,15 @@ BrowserImage::BrowserImage(const BrowserImage& copy) :
     setData(copy.getData(), copy.isSharedData(), copy.getImageType());
 }
 
-
+BrowserImage& BrowserImage::operator=(const BrowserImage& copy)
+{
+    m_width = copy.getWidth();
+    m_height = copy.getHeight();
+    m_dataSize = copy.getSize();
+    m_colorSpace = copy.getColorSpace();
+    setData(copy.getData(), copy.isSharedData(), copy.getImageType());
+    return *this;
+}
 
 void BrowserImage::setData(void* data, bool isSharedData, ImageType type)
 {
diff --git a/core/Tools/BrowserImage.h b/core/Tools/BrowserImage.h
old mode 100644
new mode 100755
index b1cb4108..6fe8462e
--- a/core/Tools/BrowserImage.h
+++ b/core/Tools/BrowserImage.h
@@ -38,6 +38,7 @@ public:
     BrowserImage(Evas_Object* image);
     BrowserImage(const BrowserImage& copy);
     ~BrowserImage();
+     BrowserImage& operator=(const BrowserImage&);
 
     /**
      * Sets image raw data pointer, type and memory share
diff --git a/services/WebPageUI/UrlHistoryList/GenlistManager.cpp b/services/WebPageUI/UrlHistoryList/GenlistManager.cpp
old mode 100644
new mode 100755
index 93808696..b66fc6f3
--- a/services/WebPageUI/UrlHistoryList/GenlistManager.cpp
+++ b/services/WebPageUI/UrlHistoryList/GenlistManager.cpp
@@ -140,8 +140,6 @@ string GenlistManager::getItemUrl(
         if (!data)
             continue;
         const UrlPair* const urlPair = reinterpret_cast<UrlPair*>(data);
-        if (!urlPair)
-            continue;
         return urlPair->urlOriginal;
     }
     return "";