From: seoz Date: Fri, 23 Dec 2011 06:52:05 +0000 (+0000) Subject: elm gengrid: Fixed crashed on Enter event with no selected item. Patch by X-Git-Tag: REL_F_I9500_20120323_1~17^2~1059 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ea9f66cbbcab6f2d94e37e83cb0dd27a3f4c9c3a;p=framework%2Fuifw%2Felementary.git elm gengrid: Fixed crashed on Enter event with no selected item. Patch by Jeonghyun Yoon 2011/12/23 윤정현 : > Dear All. > > I found a bug in elm_gengrid.c > > Gengrid will be crashed if input “Enter” key when selected is null. > > I fixed code, please review this small patch. > > Thanks. git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@66471 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c index 370dc3a..daf9bc9 100644 --- a/src/lib/elm_gengrid.c +++ b/src/lib/elm_gengrid.c @@ -325,9 +325,10 @@ _event_hook(Evas_Object *obj, ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD; return EINA_TRUE; } - else if ((!strcmp(ev->keyname, "Return")) || - (!strcmp(ev->keyname, "KP_Enter")) || - (!strcmp(ev->keyname, "space"))) + else if (((!strcmp(ev->keyname, "Return")) || + (!strcmp(ev->keyname, "KP_Enter")) || + (!strcmp(ev->keyname, "space"))) + && (!wd->multi) && (wd->selected)) { it = elm_gengrid_selected_item_get(obj); evas_object_smart_callback_call(WIDGET(it), SIG_ACTIVATED, it);