From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 22 Aug 2014 11:03:29 +0000 (+0200)
Subject: net: sctp: spare unnecessary comparison in sctp_trans_elect_best
X-Git-Tag: v4.9.8~5834^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ea4f19c1f81d4bf709c74e3789ec785828bc6e51;p=platform%2Fkernel%2Flinux-rpi3.git

net: sctp: spare unnecessary comparison in sctp_trans_elect_best

When both transports are the same, we don't have to go down that
road only to realize that we will return the very same transport.
We are guaranteed that curr is always non-NULL. Therefore, just
short-circuit this special case.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index aaafb32..104fae4 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -1245,7 +1245,7 @@ static struct sctp_transport *sctp_trans_elect_best(struct sctp_transport *curr,
 {
 	u8 score_curr, score_best;
 
-	if (best == NULL)
+	if (best == NULL || curr == best)
 		return curr;
 
 	score_curr = sctp_trans_score(curr);