From: Dinghao Liu Date: Sun, 23 Aug 2020 09:14:53 +0000 (+0800) Subject: scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort X-Git-Tag: v5.15~2812^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ea403fde7552bd61bad6ea45e3feb99db77cb31e;p=platform%2Fkernel%2Flinux-starfive.git scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort When pm8001_tag_alloc() fails, task should be freed just like it is done in the subsequent error paths. Link: https://lore.kernel.org/r/20200823091453.4782-1-dinghao.liu@zju.edu.cn Acked-by: Jack Wang Signed-off-by: Dinghao Liu Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index 337e79d..9889bab 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -818,7 +818,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha, res = pm8001_tag_alloc(pm8001_ha, &ccb_tag); if (res) - return res; + goto ex_err; ccb = &pm8001_ha->ccb_info[ccb_tag]; ccb->device = pm8001_dev; ccb->ccb_tag = ccb_tag;