From: Linus Torvalds Date: Fri, 30 Jun 2023 06:04:57 +0000 (-0700) Subject: parisc: fix expand_stack() conversion X-Git-Tag: v6.6.17~4518 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ea3f8272876f2958463992f6736ab690fde7fa9c;p=platform%2Fkernel%2Flinux-rpi.git parisc: fix expand_stack() conversion In commit 8d7071af8907 ("mm: always expand the stack with the mmap write lock held") I tried to deal with the remaining odd page fault handling cases. The oddest one is ia64, which has stacks that grow both up and down. And because ia64 was _so_ odd, I asked people to verify the end result. But a close second oddity is parisc, which is the only one that has a main stack growing up (our "CONFIG_STACK_GROWSUP" config option). But it looked obvious enough that I didn't worry about it. I should have worried a bit more. Not because it was particularly complex, but because I just used the wrong variable name. The previous vma isn't called "prev", it's called "prev_vma". Blush. Fixes: 8d7071af8907 ("mm: always expand the stack with the mmap write lock held") Signed-off-by: Linus Torvalds --- diff --git a/arch/parisc/mm/fault.c b/arch/parisc/mm/fault.c index 6e894af..a4c7c76 100644 --- a/arch/parisc/mm/fault.c +++ b/arch/parisc/mm/fault.c @@ -289,7 +289,7 @@ retry: mmap_read_lock(mm); vma = find_vma_prev(mm, address, &prev_vma); if (!vma || address < vma->vm_start) { - if (!prev || !(prev->vm_flags & VM_GROWSUP)) + if (!prev_vma || !(prev_vma->vm_flags & VM_GROWSUP)) goto bad_area; vma = expand_stack(mm, address); if (!vma)