From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 14 Jun 2022 11:21:12 +0000 (+0800)
Subject: drm/logicvc: add missing of_node_put() in logicvc_layers_init()
X-Git-Tag: v6.1-rc5~176^2~22^2~399
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9fcc60ddd29994a8b2a276ee9b454d7cd449194;p=platform%2Fkernel%2Flinux-starfive.git

drm/logicvc: add missing of_node_put() in logicvc_layers_init()

The of_node_put() need be called in error path in logicvc_layers_init().

Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220614112112.1537319-1-yangyingliang@huawei.com
---

diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index 31c5c42..441e3cf 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -613,8 +613,10 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
 		}
 
 		ret = logicvc_layer_init(logicvc, layer_node, index);
-		if (ret)
+		if (ret) {
+			of_node_put(layers_node);
 			goto error;
+		}
 	}
 
 	of_node_put(layers_node);