From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Fri, 26 Jul 2013 09:47:56 +0000 (+0200)
Subject: session: create an internal source for RTCP
X-Git-Tag: 1.19.3~509^2~5540
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9e2fe3950b771f4a5469a5463792f207320c785;p=platform%2Fupstream%2Fgstreamer.git

session: create an internal source for RTCP

When we need to do RTCP and we don't have an internal source yet,
make one.
---

diff --git a/gst/rtpmanager/rtpsession.c b/gst/rtpmanager/rtpsession.c
index 85020a8..dd25ef0 100644
--- a/gst/rtpmanager/rtpsession.c
+++ b/gst/rtpmanager/rtpsession.c
@@ -2820,7 +2820,7 @@ session_cleanup (const gchar * key, RTPSource * source, ReportData * data)
 
   /* check for outdated collisions */
   if (source->internal) {
-    GST_DEBUG ("Timing out collisions");
+    GST_DEBUG ("Timing out collisions for %x", source->ssrc);
     rtp_source_timeout (source, data->current_time,
         /* "a relatively long time" -- RFC 3550 section 8.2 */
         RTP_STATS_MIN_INTERVAL * GST_SECOND * 10,
@@ -2857,7 +2857,7 @@ session_cleanup (const gchar * key, RTPSource * source, ReportData * data)
   GST_LOG ("timeout base interval %" GST_TIME_FORMAT,
       GST_TIME_ARGS (binterval));
 
-  /* check for our own source, we don't want to delete our own source. */
+  /* FIXME, we need to remove internal sources too */
   if (!source->internal) {
     if (source->marked_bye) {
       /* if we received a BYE from the source, remove the source after some
@@ -3207,6 +3207,15 @@ rtp_session_on_timeout (RTPSession * sess, GstClockTime current_time,
   if (!is_rtcp_time (sess, current_time, &data))
     goto done;
 
+  /* we need an internal source now */
+  if (sess->stats.internal_sources == 0) {
+    RTPSource *source;
+    gboolean created;
+
+    source = obtain_internal_source (sess, sess->suggested_ssrc, &created);
+    g_object_unref (source);
+  }
+
   /* generate RTCP for all internal sources */
   g_hash_table_foreach (sess->ssrcs[sess->mask_idx],
       (GHFunc) generate_rtcp, &data);