From: Uwe Kleine-König Date: Thu, 13 Jul 2023 15:51:41 +0000 (+0200) Subject: pwm: stm32: Don't modify HW state in .remove() callback X-Git-Tag: v6.6.17~3967^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9c2f69aac05919a4f2bf72a7b53c43ac3f4c410;p=platform%2Fkernel%2Flinux-rpi.git pwm: stm32: Don't modify HW state in .remove() callback A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 62e397a..687967d 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -649,10 +649,6 @@ static int stm32_pwm_probe(struct platform_device *pdev) static void stm32_pwm_remove(struct platform_device *pdev) { struct stm32_pwm *priv = platform_get_drvdata(pdev); - unsigned int i; - - for (i = 0; i < priv->chip.npwm; i++) - pwm_disable(&priv->chip.pwms[i]); pwmchip_remove(&priv->chip); }