From: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Fri, 28 Jul 2017 12:07:39 +0000 (+0900)
Subject: evas obj smart - remove pointless if
X-Git-Tag: upstream/1.20.0~82
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9ab26ae539db23a06232e6f4fcd757347cbd46e;p=platform%2Fupstream%2Fefl.git

evas obj smart - remove pointless if

s is already checked for null... so no need to check again

found by PVS studio

@fix
---

diff --git a/src/lib/evas/canvas/evas_object_smart.c b/src/lib/evas/canvas/evas_object_smart.c
index aa849d0..0b42894 100644
--- a/src/lib/evas/canvas/evas_object_smart.c
+++ b/src/lib/evas/canvas/evas_object_smart.c
@@ -157,17 +157,14 @@ evas_object_smart_interface_get(const Evas_Object *eo_obj,
    s = evas_object_smart_smart_get(eo_obj);
    if (!s) return NULL;
 
-   if (s)
+   for (i = 0; i < s->interfaces.size; i++)
      {
-        for (i = 0; i < s->interfaces.size; i++)
-          {
-             const Evas_Smart_Interface *iface;
+        const Evas_Smart_Interface *iface;
 
-             iface = s->interfaces.array[i];
+        iface = s->interfaces.array[i];
 
-             if (iface->name == name)
-                return iface;
-          }
+        if (iface->name == name)
+          return iface;
      }
 
    return NULL;