From: Rafael J. Wysocki Date: Tue, 30 Aug 2022 18:33:37 +0000 (+0200) Subject: thermal: int340x_thermal: Consolidate priv->data_vault checks X-Git-Tag: v6.1-rc5~353^2^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9a7c526c29b0ae60c888b335bd6cf6e2ee80154;p=platform%2Fkernel%2Flinux-starfive.git thermal: int340x_thermal: Consolidate priv->data_vault checks It is sufficient to check priv->data_vault once in the error code path of int3400_thermal_probe(), so do that. Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c index 365489b..db8a6f6 100644 --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c @@ -614,9 +614,8 @@ static int int3400_thermal_probe(struct platform_device *pdev) free_sysfs: cleanup_odvp(priv); - if (priv->data_vault) { - if (!ZERO_OR_NULL_PTR(priv->data_vault)) - sysfs_remove_group(&pdev->dev.kobj, &data_attribute_group); + if (!ZERO_OR_NULL_PTR(priv->data_vault)) { + sysfs_remove_group(&pdev->dev.kobj, &data_attribute_group); kfree(priv->data_vault); } free_uuid: