From: Bjorn Helgaas Date: Thu, 6 Oct 2016 18:34:23 +0000 (-0500) Subject: PCI: hisi: Pass device-specific struct to internal functions X-Git-Tag: v4.9.8~1146^2^6~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e9480b5a7f3449f75eedb595bec25cd10a1f43f2;p=platform%2Fkernel%2Flinux-rpi3.git PCI: hisi: Pass device-specific struct to internal functions Only interfaces used from outside the driver, e.g., those called by the DesignWare core, need to accept pointers to the generic struct pcie_port. Internal interfaces can accept pointers to the device-specific struct, which makes them more straightforward. No functional change intended. Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/host/pcie-hisi.c b/drivers/pci/host/pcie-hisi.c index b508aae..bfff666 100644 --- a/drivers/pci/host/pcie-hisi.c +++ b/drivers/pci/host/pcie-hisi.c @@ -126,13 +126,13 @@ static struct pcie_host_ops hisi_pcie_host_ops = { .link_up = hisi_pcie_link_up, }; -static int hisi_add_pcie_port(struct pcie_port *pp, - struct platform_device *pdev) +static int hisi_add_pcie_port(struct hisi_pcie *hisi_pcie, + struct platform_device *pdev) { + struct pcie_port *pp = &hisi_pcie->pp; struct device *dev = pp->dev; int ret; u32 port_id; - struct hisi_pcie *hisi_pcie = to_hisi_pcie(pp); if (of_property_read_u32(dev->of_node, "port-id", &port_id)) { dev_err(dev, "failed to read port-id\n"); @@ -190,7 +190,7 @@ static int hisi_pcie_probe(struct platform_device *pdev) return PTR_ERR(pp->dbi_base); } - ret = hisi_add_pcie_port(pp, pdev); + ret = hisi_add_pcie_port(hisi_pcie, pdev); if (ret) return ret;