From: Haihua Hu <jared.hu@nxp.com>
Date: Thu, 20 Apr 2023 08:41:11 +0000 (+0800)
Subject: gstplay: fix critical log when enable playbin3
X-Git-Tag: 1.22.7~268
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e8b74ada7c4c16f16365415176a301dddecf58f6;p=platform%2Fupstream%2Fgstreamer.git

gstplay: fix critical log when enable playbin3

when play rtsp stream with playbin3 enabled, there are some critical logs:

g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-video'
g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-audio'
g_object_get_is_valid_property: object class 'GstPlayBin3' has no property named 'n-text'

self->collection could be NULL when READY->PAUSED if the pipeline
is live, then it will fallback to query playbin2's property,
we can call gst_play_streams_info_create_from_collection
directly, it will check self->collection internal.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4666>
---

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
index c88d8e9..6c66539 100644
--- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
@@ -2389,7 +2389,7 @@ gst_play_media_info_create (GstPlay * self)
     gst_query_parse_seeking (query, NULL, &media_info->seekable, NULL, NULL);
   gst_query_unref (query);
 
-  if (self->use_playbin3 && self->collection) {
+  if (self->use_playbin3) {
     gst_play_streams_info_create_from_collection (self, media_info,
         self->collection);
   } else {