From: Peter Rosin Date: Wed, 2 May 2018 07:40:24 +0000 (+0200) Subject: drm/rockchip: lvds: avoid duplicating drm_bridge_attach X-Git-Tag: v4.19~298^2~45^2~63 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e8b58d6de1fe9119018ed9bbeecf373dcc397b8d;p=platform%2Fkernel%2Flinux-rpi.git drm/rockchip: lvds: avoid duplicating drm_bridge_attach drm_bridge_attach takes care of these assignments, so there is no need to open-code them a second time. Signed-off-by: Peter Rosin Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20180502074025.12421-3-peda@axentia.se --- diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index e67f4ea..4bd94b1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -446,14 +446,12 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, goto err_free_connector; } } else { - lvds->bridge->encoder = encoder; ret = drm_bridge_attach(encoder, lvds->bridge, NULL); if (ret) { DRM_DEV_ERROR(drm_dev->dev, "failed to attach bridge: %d\n", ret); goto err_free_encoder; } - encoder->bridge = lvds->bridge; } pm_runtime_enable(dev);