From: Roel Kluin Date: Sat, 26 Dec 2009 19:31:59 +0000 (+0100) Subject: wl1251: timeout one too soon in wl1251_boot_run_firmware() X-Git-Tag: upstream/snapshot3+hdmi~15606^2~1^2~48 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e8a4a6df7397eb3b43ad3139d3fe9b41df70d6b0;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git wl1251: timeout one too soon in wl1251_boot_run_firmware() `loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE occurs in the last iteration the write occurs but also the error out as if a timeout occurred. This is probably very unlikely to ever occur. Signed-off-by: Roel Kluin Acked-by: Kalle Valo Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/wl12xx/wl1251_boot.c b/drivers/net/wireless/wl12xx/wl1251_boot.c index 2e733e7..28a8086 100644 --- a/drivers/net/wireless/wl12xx/wl1251_boot.c +++ b/drivers/net/wireless/wl12xx/wl1251_boot.c @@ -256,7 +256,7 @@ int wl1251_boot_run_firmware(struct wl1251 *wl) } } - if (loop >= INIT_LOOP) { + if (loop > INIT_LOOP) { wl1251_error("timeout waiting for the hardware to " "complete initialization"); return -EIO;