From: axel lin <axel.lin@gmail.com>
Date: Fri, 21 Jan 2011 11:18:06 +0000 (+0000)
Subject: video: pxa168fb: remove a redundant pxa168fb_check_var call
X-Git-Tag: v3.0~1973^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e88e43b0c564864c883103483bad6219f77dfb52;p=platform%2Fkernel%2Flinux-amlogic.git

video: pxa168fb: remove a redundant pxa168fb_check_var call

Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
---

diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index cea6403..35f61dd 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
 	 */
 	pxa168fb_init_mode(info, mi);
 
-	ret = pxa168fb_check_var(&info->var, info);
-	if (ret)
-		goto failed_free_fbmem;
-
 	/*
 	 * Fill in sane defaults.
 	 */
 	ret = pxa168fb_check_var(&info->var, info);
 	if (ret)
-		goto failed;
+		goto failed_free_fbmem;
 
 	/*
 	 * enable controller clock