From: Sebastian Dröge <sebastian@centricular.com>
Date: Thu, 2 Jan 2014 10:09:59 +0000 (+0100)
Subject: tee: Keep another ref to our one and only srcpad around while pushing
X-Git-Tag: 1.3.1~249
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e80fd39947c697d591789feee918cd6a27f1ca15;p=platform%2Fupstream%2Fgstreamer.git

tee: Keep another ref to our one and only srcpad around while pushing

A pad probe on that pad might otherwise just release the pad, drop
the last reference and cause great misery.

https://bugzilla.gnome.org/show_bug.cgi?id=721300
---

diff --git a/plugins/elements/gsttee.c b/plugins/elements/gsttee.c
index a6d4b9d..4231563 100644
--- a/plugins/elements/gsttee.c
+++ b/plugins/elements/gsttee.c
@@ -591,6 +591,9 @@ gst_tee_handle_data (GstTee * tee, gpointer data, gboolean is_list)
   if (!pads->next) {
     GstPad *pad = GST_PAD_CAST (pads->data);
 
+    /* Keep another ref around, a pad probe
+     * might release and destroy the pad */
+    gst_object_ref (pad);
     GST_OBJECT_UNLOCK (tee);
 
     if (pad == tee->pull_pad) {
@@ -600,6 +603,9 @@ gst_tee_handle_data (GstTee * tee, gpointer data, gboolean is_list)
     } else {
       ret = gst_pad_push (pad, GST_BUFFER_CAST (data));
     }
+
+    gst_object_unref (pad);
+
     return ret;
   }